GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Split operator.py into multiple files by eriknw · Pull Request #420 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Mar 29, 2023

Copy link
Copy Markdown
Member

This addresses some of the feedback from #410.

I've tried to do this in the past, but always failed. I think we've finally untangled things enough to allow this, b/c I succeeded this time!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
Split operator.py into multiple files
3128130
@eriknw eriknw added the hygiene Improve code quality and reduce maintenance overhead label Mar 29, 2023
eriknw added 2 commits March 29, 2023 13:23
@eriknw
Ensure tomli is installed when testing
2eeb0c9
@eriknw
oops forgot pickle files for suitesparse-vanilla
026119a
@coveralls

coveralls commented Mar 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 99.471% (-0.02%) from 99.491% when pulling 81ea188 on eriknw:split_operator into 0139a83 on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
Try to fix test_packages on Windows
d5a4456
@eriknw
eriknw requested review from SultanOrazbayev and jim22k March 29, 2023 18:58
eriknw added 2 commits March 29, 2023 14:11
@eriknw
Try to fix operator usage in numpy.py in operators
29e5219
@eriknw
ruff 260
81ea188
jim22k
jim22k approved these changes Mar 31, 2023
View reviewed changes
@eriknw

eriknw commented Mar 31, 2023

Copy link
Copy Markdown
Member Author

Thanks for reviewing Jim--merging!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw merged commit 40e548d into python-graphblas:main Mar 31, 2023
@eriknw eriknw mentioned this pull request May 8, 2023
Python-graphblas: high-performance sparse linear algebra for scalable graph analytics pyOpenSci/software-submission#81
Closed
11 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim22k jim22k jim22k approved these changes
@SultanOrazbayev SultanOrazbayev Awaiting requested review from SultanOrazbayev

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

hygiene Improve code quality and reduce maintenance overhead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eriknw @coveralls @jim22k
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.