GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Convert logo from font svg into path svg by jim22k · Pull Request #447 · python-graphblas/python-graphblas

Conversation

@jim22k

@jim22k jim22k commented Apr 24, 2023

Copy link
Copy Markdown
Member

Same thing we did for graphblas-algorithms -- change from a small svg which uses built-fonts and instead use an explicit path to remove the font challenges. This has been run thru a minifier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jim22k
Convert logo from font svg into path svg
3e8d4c3
@coveralls

coveralls commented Apr 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 99.698% (+5.6%) from 94.056% when pulling 13586a8 on jim22k:logo_svg into 1ed40ef on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jim22k
Convert all logos from font svg to path svg
3d98be4
@eriknw

eriknw commented Apr 25, 2023

Copy link
Copy Markdown
Member

Yay, thanks @jim22k!

Which minifier did you use? One of the tools I tried when doing python-graphblas/graphblas-algorithms#60 actually lowered the quality of the svg, but I forget which one.

https://vecta.io/nano appears to do a good job and is high quality.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
minify all svgs with https://vecta.io/nano
13586a8
@eriknw

eriknw commented Apr 25, 2023

Copy link
Copy Markdown
Member

I just minified all svgs with https://vecta.io/nano . I can't tell a difference. The size of the logos was reduced by another third or so.
jim22k reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw self-requested a review April 26, 2023 14:29
eriknw
eriknw approved these changes Apr 26, 2023
View reviewed changes
@jim22k
jim22k merged commit 3f05a3d into python-graphblas:main Apr 26, 2023
@eriknw eriknw mentioned this pull request May 8, 2023
Python-graphblas: high-performance sparse linear algebra for scalable graph analytics pyOpenSci/software-submission#81
Closed
11 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriknw eriknw eriknw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jim22k @coveralls @eriknw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.