GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Split `io.py` into multiple files by eriknw · Pull Request #448 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Apr 26, 2023

Copy link
Copy Markdown
Member

Splitting io.py into separate files was brought up in #435 and #436, which I think is a good idea.

I kept the submodules hidden in this PR (such as _networkx.py), because I'm not sure I like the current names. Also, I think tab-completing gb.io.<TAB> is good enough for users to find the functions they want. Since each submodule probably won't have that many functions--all currently have two--I think it would detract if we had e.g. networkx in addition to from_networkx and to_networkx in gb.io.

Linting tools actually made this pretty easy to do, b/c they clean up imports I don't use and tell me which functions I need to import.

This PR does not yet use automodule as suggested in #436. I think we should still consider doing so.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
Split io.py into multiple files
8a9239b
@eriknw eriknw added hygiene Improve code quality and reduce maintenance overhead io Data input, output, and conversions labels Apr 26, 2023
@coveralls

coveralls commented Apr 26, 2023

Copy link
Copy Markdown

Coverage Status

Coverage: 99.802% (+5.7%) from 94.056% when pulling 8a9239b on eriknw:split_io into 1ed40ef on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw merged commit 0590051 into python-graphblas:main Apr 26, 2023
@eriknw eriknw mentioned this pull request May 8, 2023
Python-graphblas: high-performance sparse linear algebra for scalable graph analytics pyOpenSci/software-submission#81
Closed
11 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

hygiene Improve code quality and reduce maintenance overhead io Data input, output, and conversions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eriknw @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.