GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — include conftest.py in MANIFEST.in by eriknw · Pull Request #451 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented May 5, 2023

Copy link
Copy Markdown
Member

We somehow forgot to include this. Still need to verify that including this allows us to run tests with custom options, but I think it should.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw eriknw added hygiene Improve code quality and reduce maintenance overhead tests Unit tests and/or continuous integration labels May 5, 2023
@eriknw
include conftest.py in MANIFEST.in
47d09f5
@coveralls

coveralls commented May 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 98.99% (-0.5%) from 99.54% when pulling 756dc68 on eriknw:include_conftest into 0eeebfc on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
Run slow tests when running via pytest --pyargs graphblas
9bb8cb2
@eriknw

eriknw commented May 5, 2023

Copy link
Copy Markdown
Member Author

Okay, so adding conftest.py to MANIFEST.in actually doesn't add it to the wheel--it's only added to the source distribution. It belongs in the source distribution, so this change is still good.

I just added some logic so that slow tests will run (and not emit warnings) when run via pytest --pyargs graphblas. It also runs "randomly". I don't know how to allow custom cli arguments to be passed in when pytest is invoked in this way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eriknw added 2 commits May 6, 2023 07:51
@eriknw
bump ruff (also, test pre-commit.ci)
5a2ad3c
@eriknw
pre-commit.ci works fine, let's only use it for linting
756dc68
@eriknw
eriknw merged commit f140f9c into python-graphblas:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

hygiene Improve code quality and reduce maintenance overhead tests Unit tests and/or continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eriknw @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.