GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Removed deprecated draw by paul-tqh-nguyen · Pull Request #485 · python-graphblas/python-graphblas

Conversation

@paul-tqh-nguyen

@paul-tqh-nguyen paul-tqh-nguyen commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw

eriknw commented Jul 22, 2023

Copy link
Copy Markdown
Member

Thanks @paul-tqh-nguyen, welcome as a contributor!

Oh, looks like we did miss a usage of gb.io.draw in the docs. docs/api_reference/io.rst uses graphblas.io.draw. Maybe change that to graphblas.viz.draw or just remove it. Visualization probably deserves its own page.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Jul 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 99.376% (+0.3%) from 99.107% when pulling 46209e8 on paul-tqh-nguyen:paulnguyen/rm_deprecated_0 into 8bd80f6 on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@paul-tqh-nguyen
Removed deprecated draw
46209e8
@paul-tqh-nguyen
paul-tqh-nguyen force-pushed the paulnguyen/rm_deprecated_0 branch from 095388d to 46209e8 Compare July 26, 2023 14:07
@paul-tqh-nguyen

paul-tqh-nguyen commented Jul 26, 2023

Copy link
Copy Markdown
Contributor Author

I made the minimal change needed to pass CI. I think making a dedicated viz page would make sense, but it probably out of the scope of this PR.
eriknw reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw

eriknw commented Jul 26, 2023

Copy link
Copy Markdown
Member

LGTM, thanks @paul-tqh-nguyen--welcome as a contributor!
SultanOrazbayev reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw merged commit ae0366a into python-graphblas:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@paul-tqh-nguyen @eriknw @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.