GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — dropping support for python3.8 by Transurgeon · Pull Request #489 · python-graphblas/python-graphblas

Conversation

@Transurgeon

@Transurgeon Transurgeon commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Made changes to dependencies, pyproject.toml and CI workflows according to the instructions listed on the wiki.
However, I wasn't sure what to change for this particular instruction:
- Update minimum dependency versions to match what we test
Removing support of a Python version is a natural time to remove supported versions of dependencies, which we may support for much longer than 24 months if it's trivial to do so.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Transurgeon
dropping support for python3.8 according to wiki
bf65519
@eriknw

eriknw commented Aug 9, 2023

Copy link
Copy Markdown
Member

Thanks @Transurgeon! Welcome as a contributor 🎉

These changes look perfect to me to drop Python 3.8 👍

For reference, NEP 29 dropped Python 3.8 support in April this year, and SPEC 0 dropped it about a year ago:

  • https://numpy.org/neps/nep-0029-deprecation_policy.html
  • https://scientific-python.org/specs/spec-0000/

However, I wasn't sure what to change for this particular instruction:

Update minimum dependency versions to match what we test

Aha, it means to update the minimum dependency versions in pyproject.toml if removing Python 3.8 from CI means that we no longer test some versions of dependencies. We still test the same versions of dependencies as we did when we tested with Python 3.8, so no changes are necessary this time.

I will update the instructions on the wiki to mention pyproject.toml, b/c I agree that wasn't clear. Thanks for the feedback.

Removing support of a Python version is a natural time to remove supported versions of dependencies, which we may support for much longer than 24 months if it's trivial to do so.

This means that if we want to, we can also change what versions of dependencies we support. This is completely optional, and I don't want to think about it right now, so let's do nothing :)

Merging!

SultanOrazbayev reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eriknw
eriknw merged commit 9e1a390 into python-graphblas:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Transurgeon @eriknw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.