GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for Python 3.12 by eriknw · Pull Request #508 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Oct 8, 2023

Copy link
Copy Markdown
Member

Also, test against python-suitesparse-graphblas 8.2.0.1

I followed the instructions: https://github.com/python-graphblas/python-graphblas/wiki/Support-new-Python-version

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erik and others added 10 commits October 8, 2023 17:04
Erik Erik
Add support for Python 3.12
d16ee09 
Also, test against python-suitesparse-graphblas 8.2.0.1
@eriknw
coveralls doesn't support Python 3.12... should we drop it?
10c6506
@eriknw
oops
c325c7a
@eriknw
fix, and allow suitesparse-graphblas 8 to be installed
54e200c 
b/c ssgb 8.2.0.1 is the only one that supports Python 3.12
@eriknw
Better handle python-suitesparse-graphblas version in CI workflow
093392c
@eriknw
matplotlib does not yet support Python 3.12
2127473
@eriknw
haha, oops
a84b334
@eriknw
try this
8afc0eb
@eriknw
Try this workaround instead
7ca2bfb
@eriknw
Wait for matplotlib to be released for Python 3.12
e30fd37
@eriknw

eriknw commented Oct 8, 2023

Copy link
Copy Markdown
Member Author

I think this is very close, but for sanity, I'd like to wait until matplotlib has been released and built for Python 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@galaxy001

galaxy001 commented Oct 11, 2023

Copy link
Copy Markdown

matplotlib support python 3.12 now.
https://pypi.org/project/matplotlib/3.8.0/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
Ready to merge (change weights in CI for 3.12 to 1)
1ed0079
@eriknw

eriknw commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

Thanks @galaxy001, right you are--good timing! Plus, Python 3.12 support just arrived this morning for matplotlib on conda-forge.

Now we just need to wait for tests to pass :)

Another things this PR portends is that we will likely stop using coveralls.io soon and rely only on codecov.io for coverage services. coveralls does not appear to be well-maintained for Python, and it restricts our version of coverage, which may be causing other headaches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Oct 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 99.725% (+0.01%) from 99.715% when pulling 22aa0df on eriknw:py312 into 43deb66 on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
Update codecov config
22aa0df
@eriknw
eriknw merged commit 39d52b1 into python-graphblas:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eriknw @galaxy001 @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.