GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add docstrings for using SS JIT, and make better by eriknw · Pull Request #512 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Oct 15, 2023

Copy link
Copy Markdown
Member

Also:

  • allow a SS JIT function to be registered under the same name with different input types
  • be extra-strict about input types for SS JIT
  • test numba JIT with select with udt

CC @michelp in case you want to look at the docstrings and signatures of our functions for using SuiteSparse:GraphBLAS JIT such as gb.binary.ss.register_new--I think you're the most likely to show off something cool using the JIT ;)
(also, let me know if you want help using the JIT locally).

I think we should cut a new release after this is merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
eriknw added 5 commits October 15, 2023 13:12
@eriknw
Add docstrings for using SS JIT, and make better
7a68143 
Also:
- allow a SS JIT function to be registered under the same name with different input types
- be extra-strict about input types for SS JIT
- test numba JIT with select with udt
@eriknw
dunno if mamba doesn't do this strictly or not, but strict is needed
75a67bc
@eriknw
Fix when numba is not installed
ab066c2
@eriknw
black is back
b5d14de
@eriknw
codecov annotations in github are super annoying
feca933
@codecov

codecov Bot commented Oct 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #512 (f36002e) into main (cb9be54) will increase coverage by 6.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   92.86%   99.58%   +6.71%     
==========================================
  Files          95       95              
  Lines       21106    21253     +147     
  Branches     3950     3987      +37     
==========================================
+ Hits        19600    21164    +1564     
+ Misses       1342       65    -1277     
+ Partials      164       24     -140
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
michelp
michelp approved these changes Oct 17, 2023
View reviewed changes

@michelp michelp left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
eriknw added 2 commits October 16, 2023 21:35
@eriknw
Try different layout for codecov PR comment (what is header and footer?)
76f28ee
@eriknw
Don't need footer in codecov comment
f36002e
@eriknw

eriknw commented Oct 17, 2023

Copy link
Copy Markdown
Member Author

Thanks for taking a look @michelp!

So I added codecov github comment in this PR. I don't know if I like it, but it's convenient to have an easy link to the coverage report. I made the message not quite as ugly as the default.

Anyway, merging! I'll get overall approval from others before I do a release, which is coming soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw merged commit f0fd194 into python-graphblas:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@michelp michelp michelp approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eriknw @michelp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.