GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support `A.power(0)` by eriknw · Pull Request #518 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Nov 4, 2023

Copy link
Copy Markdown
Member

CC @michelp who requested this.

When n=0, I decided to create a complete diagonal matrix using the identity of the binaryop if the identity exists (and raise if it doesn't).

We want the following equality to hold:

I = A.power(0, semiring)
semiring(I @ A @ I).isequal(A)

We could try to make the diagonal more sparse to better support hypersparse matrices, but this would need to determine both nonempty rows and nonempty columns, because I needs to be able to be the left-identity and the right-identity. Creating the complete diagonal matrix is much simpler.

CC @jim22k. When we added Matrix.power in #483, I believe we discussed n=0, and we decided to punt until it was needed. As we discussed, n=0 is a little awkward b/c the identity value isn't always available (since it ought to come from the binaryop--not the monoid--of the semiring), and we weren't sure whether we should try to return a sparse diagonal or if this is what the user would want and expect. I think the behavior in this PR is the best approach.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@eriknw
Support A.power(0)
5bddc8c
@codecov

codecov Bot commented Nov 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #518 (5bddc8c) into main (7935e50) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   99.20%   99.24%   +0.04%     
==========================================
  Files          95       95              
  Lines       21291    21305      +14     
  Branches     3999     4001       +2     
==========================================
+ Hits        21121    21144      +23     
+ Misses        124      112      -12     
- Partials       46       49       +3     
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

michelp
michelp approved these changes Nov 4, 2023
View reviewed changes
@eriknw eriknw mentioned this pull request Nov 4, 2023
Add semiring(A @ B @ C) that applies semiring to both matmuls #501
Merged
4 tasks done
@eriknw
eriknw merged commit 0bfcb66 into python-graphblas:main Dec 12, 2023
@eriknw eriknw added the enhancement Improve existing functionality or make things work better label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@michelp michelp michelp approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Improve existing functionality or make things work better

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eriknw @michelp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.