GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add 9.4.5.0 to tests by jim22k · Pull Request #557 · python-graphblas/python-graphblas

Conversation

@jim22k

@jim22k jim22k commented Feb 26, 2025

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jim22k
Add 9.4.5.0 to tests
bf9776c
@jim22k
jim22k requested a review from eriknw February 26, 2025 15:30
@codecov

codecov Bot commented Feb 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (522b696) to head (bf9776c).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   99.13%   99.40%   +0.26%     
==========================================
  Files          93       93              
  Lines       21855    21941      +86     
  Branches     4130     2672    -1458     
==========================================
+ Hits        21667    21810     +143     
+ Misses        121       98      -23     
+ Partials       67       33      -34
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eriknw
eriknw approved these changes Feb 26, 2025
View reviewed changes

@eriknw eriknw left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jim22k, looks great! I ran CI twice for sanity.

#546 made these branches of setting psgver a bit more clear by doing each Python version and source or upstream, but it does add some duplication and additional effort to add new versions. Hopefully it's not too bad. Simple is probably better than fancy here if we look at it every 6-12 months.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
eriknw merged commit 22d42f6 into python-graphblas:main Feb 26, 2025
@eriknw

eriknw commented Feb 26, 2025

Copy link
Copy Markdown
Member

Also worth noting that we don't need a new release to update metadata since the latest release uses this constraint:

python-graphblas/pyproject.toml

Line 75 in 22d42f6

suitesparse = ["suitesparse-graphblas >=7.4.0.0, <10"]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriknw eriknw eriknw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jim22k @eriknw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.