GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — Reject building a user monoid from a built-in BinaryOp by eriknw · Pull Request #617 · python-graphblas/python-graphblas Conversation
Member
Registering a monoid from a built-in binaryop used to crash partway and by the time it raised, it had already repointed binary.max's monoid Even patched over, the result would lie. SuiteSparse ignores the The override applies to exactly the ops that have built-in monoids (max, Monoid._build now rejects built-in binaryops up front with a TypeError
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
dbce7b2 to
488622d
Compare
This was referenced
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
488622d to
8f138a4
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
8f138a4 to
2c9fdaa
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
2c9fdaa to
88922bd
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
88922bd to
99668c2
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
99668c2 to
1b70585
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
1b70585 to
076218f
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
2 times, most recently
from
1ddb541 to
dd0e7ef
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
dd0e7ef to
35065c5
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
35065c5 to
727fe12
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
727fe12 to
896cbc8
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
896cbc8 to
c14bd42
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
c14bd42 to
a303e64
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
a303e64 to
654b144
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
654b144 to
c7ab91b
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
be1975f to
b55b217
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
b55b217 to
0b9e279
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
3 times, most recently
from
0291da9 to
5012466
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
5012466 to
68a11e3
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
68a11e3 to
d100dfa
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
2 times, most recently
from
6c76440 to
fe3d69d
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
fe3d69d to
286cb5a
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
from
286cb5a to
1198675
Compare
eriknw
force-pushed
the
36-monoid-builtin-binaryop-guard
branch
2 times, most recently
from
7cfc1e1 to
d3533cb
Compare
|
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #617 +/- ## ========================================== + Coverage 98.72% 98.82% +0.10% ========================================== Files 105 105 Lines 31088 31099 +11 Branches 3646 3647 +1 ========================================== + Hits 30691 30733 +42 + Misses 247 227 -20 + Partials 150 139 -11 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| def _build(cls, name, binaryop, identity, *, is_idempotent=False, anonymous=False): | ||
| if type(binaryop) is not BinaryOp: | ||
| raise TypeError(f"binaryop must be a BinaryOp, not {type(binaryop)}") | ||
| if _is_builtin_binaryop(binaryop): |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether it's actually worth making _is_builtin_binaryop a single-line helper functions that is used in one location.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.