GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Validate local settings before queuing a batch by edsonsims · Pull Request #1340 · python-hyper/h2 ConversationA rejected I validate the complete batch against the existing rules before queueing any values. This preserves the existing error type, code and message, connection-state error precedence, valid update ordering, and unknown setting codes. The change is limited to Twelve new cases fail before the fix; all 16 regression/control cases pass afterward. The full suite passes 1,678 tests with 100% statement and branch coverage on Python 3.10, 3.12 and 3.13. Ruff, strict-bytes mypy, manifest/package checks, strict distribution checks and the documentation build pass. A fresh installed wheel also passes 12 paired-peer checks outside the checkout. No sockets or external service are needed for these tests.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsKeep the new dev changelog sections and the existing settings-update bugfix entry. The existing settings source and regression files remain byte-identical to the prior PR head. Checks: 1700 tests passed, configured statement and branch coverage 100%, Ruff passed, and mypy passed for 13 files on local Python 3.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |