GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — Accept 204/304 responses with content-length and no body by feiiiiii5 · Pull Request #1341 · python-hyper/h2 ConversationWhat is wrongRFC 9113 § 8.1.1 defines 204, 304 and the response to HEAD as messages that have no content, and says such a message may carry a non-zero The same applies to 204. This rejects a legitimate response depending only on which frame carried END_STREAM. What changes
TestsNew
On the parent revision the two empty-DATA bodyless cases fail with
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsRFC 9113 section 8.1.1 lists 204, 304 and the response to HEAD as messages defined to have no content, and allows a non-zero content-length. Only HEAD was exempt, so a 304 or 204 with content-length was accepted when END_STREAM was on HEADERS but rejected with an empty DATA frame. Concretize the header block once and apply the same exemption to 204/304.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |