GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(stream): treat 204/304 as content-less and check HEADERS-ended bodies by feiiiiii5 · Pull Request #1344 · python-hyper/h2 ConversationWhat this fixesA 304 or 204 response carrying a non-zero RFC 9113 § 8.1.1 defines 204, 304 and the response to HEAD as having no content, and RFC 9110 § 8.6 says such a message may carry a non-zero content-length. The implementation only exempted HEAD, and only the DATA framing ran Fixes #1330. Changes
Testing
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…dies A 304/204 response with content-length was accepted or rejected purely by framing: HEADERS END_STREAM skipped the length check, while an empty DATA END_STREAM hit expected=1234. Exempt 204 and 304 like HEAD (RFC 9113 8.1.1) and run the end-of-stream content-length check when a non-trailers HEADERS block ends the stream, so 204/304/HEAD pass and a lying content-length on a normal response is rejected under either framing. Cover both 204/304 framings and HEADERS-ended 200/POST bodies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. A 304 with content-length is accepted or rejected by framing aloneUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |