GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Document receive window configuration with automatic flow control by FFspiky · Pull Request #1349 · python-hyper/h2

Conversation

@FFspiky

@FFspiky FFspiky commented Nov 11, 2026

Copy link
Copy Markdown

Document configuring receive windows with automatic flow control

Refs #1280.

The automatic flow-control guide explains acknowledging processed data but does not explain how to enlarge the connection receive window while retaining automatic replenishment. The existing increment_flow_control_window() already raises the window manager's maximum when the resulting current window exceeds it.

Document a one-time startup increment to a 1 MiB connection window, separate 256 KiB stream settings, SETTINGS acknowledgement timing, and subsequent replenishment through acknowledge_received_data(). Explain the difference between an increment and a target, the current and maximum windows, and the protocol limits. Add the same clarification to the increment method's API documentation. This introduces no API or runtime behavior change.

Add 24 frame-level cases using two in-memory peers, with either client or server receiving. They compare default and enlarged connection ACK thresholds over repeated cycles, include padded DATA, check exact WINDOW_UPDATE and SETTINGS/ACK bytes, distinguish connection/stream and send/receive windows, exercise existing and new streams, reach the maximum window without allocating a maximum-sized payload, and cover zero/negative acknowledgements, invalid increments, and negative stream credit after a SETTINGS decrease.

Validation on macOS arm64, CPython 3.12.14:

  • Baseline: 1,684 passed, 100% statement and branch coverage.
  • Final: 1,708 passed, 100% statement and branch coverage.
  • All 24 added cases also pass against the original runtime: this clarifies and protects existing behavior.
  • A separate mutation disabling maximum-window growth causes six new cases to fail.
  • Ruff source/new-test checks, strict-bytes mypy, Sphinx HTML with warnings as errors, and execution of the exact documentation example pass.

The full Python matrix and h2spec were not run locally. No network throughput benchmark is claimed. Prepared with AI assistance; external review has not occurred.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@FFspiky
Document receive window configuration with automatic flow control
9082966
Explain startup connection increments and independent stream settings, backed by frame-level coverage of replenishment and protocol limits.

Refs python-hyper#1280.

Assisted-by: Codex
@FFspiky FFspiky mentioned this pull request Nov 11, 2026
Preserve receive windows when local increments overflow #1350
Open
@FFspiky

FFspiky commented Nov 12, 2026

Copy link
Copy Markdown
Author

Both this PR and #1350 have CI runs waiting for approval before jobs can start: #1349 CI and #1350 CI. Could a maintainer review and approve them when convenient? The PR descriptions include local tests and coverage; the upstream Python matrix and h2spec still need to run.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@FFspiky
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.