GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Document connection state transition timing by Mirochill · Pull Request #201 · python-hyper/wsproto

Conversation

@Mirochill

@Mirochill Mirochill commented May 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

  • clarify that received bytes are parsed by receive_data() while event-driven state changes are applied as events() is consumed
  • document the remote-close case explicitly in both the generated API docs and the Connection method docstrings

Why

Issue #181 points out that it is easy to assume a remote close frame moves the connection into REMOTE_CLOSING during receive_data(), when the current implementation actually performs that transition while yielding the corresponding CloseConnection event from events().

Validation

  • Not run locally
  • Relying on static review of the diff and the repository's remote CI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mirochill
Document connection state transition timing
241aaaa
@Mirochill
Mirochill marked this pull request as ready for review May 18, 2026 17:35
@Kriechi
Kriechi merged commit b2239f4 into python-hyper:main May 18, 2026
7 of 8 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Mirochill @Kriechi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.