GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Allow getting Annotated features from modules by sdb9696 · Pull Request #1018 · python-kasa/python-kasa

Conversation

sdb9696 commented Jun 26, 2024 •

edited by rytilahti

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Fixes #1008

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Expose fan_speed_level feature to allow accessing range values from t…

ac3718c

…he module api

codecov Bot commented Jun 26, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.19%. Comparing base (cae9dec) to head (8c174c3).
Report is 154 commits behind head on master.

Files with missing lines	Patch %	Lines
kasa/module.py	86.48%	1 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
- Coverage   92.22%   92.19%   -0.03%     
==========================================
  Files         117      117              
  Lines        7497     7536      +39     
  Branches      775      785      +10     
==========================================
+ Hits         6914     6948      +34     
- Misses        433      434       +1     
- Partials      150      154       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sdb9696 added this to the 0.7.1 milestone

Jul 2, 2024

sdb9696 added the enhancement New feature or request label

Jul 2, 2024


          Merge branch 'master' into feat/fan_range

7eab349

sdb9696 removed this from the 0.7.1 milestone

Aug 30, 2024

sdb9696 added the no-stale label

Sep 27, 2024

Steven B added 3 commits

October 8, 2024 15:23


          Merge remote-tracking branch 'upstream/master' into feat/fan_range

56af352


          Use typing.Annotated at runtime to get feature from a property

1ce05e5


          Import TypeAlias and Self from typing_extensions for python3.9 and 3.10

1f5b382

sdb9696 force-pushed the feat/fan_range branch from 431cd8d to 1f5b382 Compare

October 9, 2024 16:08

rytilahti reviewed

Oct 9, 2024

View reviewed changes

ghost left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of quick notes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

kasa/smart/modules/fan.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

kasa/module.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

kasa/module.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address review suggestions

fe320ff

sdb9696 changed the title ~~Expose fan_speed_level feature to allow accessing range values~~ Allow getting Annotated features from modules

Oct 9, 2024

sdb9696 requested a review from rytilahti

October 9, 2024 18:24

Steven B added 4 commits

November 20, 2024 16:04


          Merge remote-tracking branch 'upstream/master' into feat/fan_range

8c76e57


          Simplify logic for checking feature and do not annotate both ways

98b3243


          Fix property name for <python3.13

8ee6d06


          Merge branch 'master' into feat/fan_range

rytilahti approved these changes

Nov 21, 2024

View reviewed changes

ghost left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than the earlier draft and design, I think this will serve us well!

I added a couple of suggestions to make the code easier to read, mostly adding some whitespace to separate different logical units & exit points. Feel free to apply whichever you feel useful and ignore the rest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

c64b50b

Co-authored-by: Teemu R. <[email protected]>


          Revert change isinstance check to Callable

8c174c3

sdb9696 enabled auto-merge (squash)

November 22, 2024 07:50

sdb9696 merged commit 37cc4da into master

Nov 22, 2024

sdb9696 deleted the feat/fan_range branch

November 22, 2024 07:52

sdb9696 removed the no-stale label

Nov 23, 2024

sdb9696 mentioned this pull request

Nov 25, 2024

Prepare 0.8.0 #1312

Merged

Reviewers

rytilahti

rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose Fan speed range from the library

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sdb9696 commented Jun 26, 2024 • edited by rytilahti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sdb9696 commented Jun 26, 2024 •

edited by rytilahti

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Jun 26, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.