GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix switching off light strip effects by sdb9696 · Pull Request #1024 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdb9696
Fix turning light effect off
3e65cfd
@codecov

codecov Bot commented Jul 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (8af23c8) to head (3e65cfd).

Additional details and impacted files 
@@                    Coverage Diff                    @@
##           fix/effect_brightness    #1024      +/-   ##
=========================================================
- Coverage                  91.38%   91.37%   -0.01%     
=========================================================
  Files                         84       84              
  Lines                       5720     5716       -4     
  Branches                    1392     1389       -3     
=========================================================
- Hits                        5227     5223       -4     
  Misses                       383      383              
  Partials                     110      110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rytilahti
rytilahti reviewed Jul 1, 2024
View reviewed changes
Comment thread kasa/smart/modules/lightstripeffect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
rytilahti
rytilahti approved these changes Jul 1, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works on L920 and L900, thanks a lot!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti
rytilahti merged commit 88e3310 into fix/effect_brightness Jul 1, 2024
@rytilahti
rytilahti deleted the fix/effect_off branch July 1, 2024 11:30
@sdb9696 sdb9696 added the bug Something isn't working label Jul 1, 2024
@sdb9696 sdb9696 added this to the 0.7.0.2 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.7.0.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.