GeezerVison is showing github.com — Add alert volume setting to water leak sensor by rytilahti · Pull Request #1163 · python-kasa/python-kasa
Conversation
rytilahti
commented
Oct 9, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR makes the water leak alert volume level configurable.
Marking a draft as this requires finding a solution for child device queries, similar to #1141.
This device also has the following commands (similar to hub alarm) for testing the alarm:
play_alarm {"volume": "low"}stop_alarm
Maybe this should be also exposed through alarm entity platform on homeassistant.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.