GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add turnonbehaviormodule for iot by rytilahti · Pull Request #1288 · python-kasa/python-kasa

Conversation

rytilahti commented Nov 20, 2024

Copy link

Copy Markdown

Member

A draft PR used for testing #1285.

== Configuration ==
Turn on hard (turn_on_hard): *BehaviorMode.Last* customize_preset circadian
Turn on soft (turn_on_soft): *BehaviorMode.Last* customize_preset circadian

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rytilahti changed the title ~~Migrate TurnOnBehaviours to mashumaro~~ Add turnonbehaviormodule for iot

Nov 20, 2024

rytilahti mentioned this pull request

Nov 20, 2024

Migrate TurnOnBehaviours to mashumaro #1285

Merged


          Add turnonbehaviormodule for iot

de8710b

rytilahti force-pushed the feat/iotbulb_turnonbehavior branch from dbefbe8 to de8710b Compare

November 20, 2024 14:36

rytilahti commented

Nov 20, 2024

View reviewed changes

Comment thread

kasa/iot/iotbulb.py

		self.add_module(Module.Time, Time(self, "smartlife.iot.common.timesetting"))
		self.add_module(
		Module.IotTurnOnBehavior,
		TurnOnBehaviorModule(self, "smartlife.iot.smartbulb.lightingservice"),

rytilahti Nov 20, 2024

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named as Module, as TurnOnBehavior is already taken by the model... We probably want to make a breaking change here, and rename the models to something else.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot commented Feb 19, 2025

Copy link

Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale label

Feb 19, 2025

rytilahti added no-stale and removed stale labels

Feb 19, 2025

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

no-stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.