GeezerVison

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (cb89342) to head (1c25091).
Report is 9 commits behind head on master.

@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         122      122           
  Lines        7867     7867           
  Branches      810      810           
=======================================
  Hits         7248     7248           
  Misses        454      454           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I agree with the setting to zero, but I’m not sure about the value of the rename. Whilst I get that it’s a bit confusing, we’re still left with consumption_today, consumption_this_month etc. It’s a lot of churn to deprecate all this, when updating the docstrings to make clearer this is what the device reports as power could suffice.

Yeah I was starting to doubt the cost of the change relative to its’ value. I can see that it would cost the long term history graphs of the power draw metrics in home assistant, but from what I could tell it would leave the energy monitoring integration mostly intact since that uses the accumulated consumption metrics instead of the instantaneous demand values.

I think the term just confuses me since it is current_consumption rather than consumption_current or consumption_now to match the pattern of the other metrics. I see that it is inherited from TPLink themselves though, so I suppose if you are trying to stay as close to the way TPLink phrased it, the current name makes sense (although I’m still not a fan of overloading the term current in this context).

I’ll get the zero setting extracted into a separate PR, since there’s no use in holding that back for this PR.

I've extracted the zero power reporting fix into PR #1483

We could still look into renaming while keeping the deprecated names available for the time being. The only one we cannot change that easily is the feature identifier (which is used as a unique key).

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!