GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve hub child module data across partial updates by o-gent · Pull Request #1813 · python-kasa/python-kasa

Conversation

@o-gent

@o-gent o-gent commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Split from #1806.

Merge child module responses into the existing cache instead of discarding data for modules not due for refresh.

The independent regression uses existing Cloud and TriggerLogs modules on H100 and KH100 children. Both cases fail before the fix and pass afterward, without skipping.

Validation: child-device tests, Ruff checks, and targeted mypy passed.

Please merge before either new 15-minute history module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@o-gent
o-gent marked this pull request as ready for review October 25, 2026 23:01
@o-gent o-gent mentioned this pull request Oct 25, 2026
Add TemperatureHumidityRecords module #1817
Draft
@codecov

codecov Bot commented Oct 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (e29864b) to head (7fb9009).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   93.43%   93.44%   +0.01%     
==========================================
  Files         160      160              
  Lines       10095    10113      +18     
  Branches     1042     1045       +3     
==========================================
+ Hits         9432     9450      +18     
  Misses        471      471              
  Partials      192      192

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti

rytilahti commented Oct 26, 2026

Copy link
Copy Markdown
Member

Could this be related to #1804 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti rytilahti added the bug Something isn't working label Oct 26, 2026
rytilahti
rytilahti requested changes Nov 1, 2026
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @o-gent! This looks like a reasonable change, but please add some debug-level logging to make it easier to debug potential issues caused by caching the responses.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread kasa/smart/smartchilddevice.py
Comment on lines +105 to +106
# Modules not due for an update still need their cached responses.
self._last_update.update(resp)

@rytilahti rytilahti Oct 31, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach is great and I agree that we should do this! Please add a debug log entry for the case when the data was not received, as that can help debugging caching issues this may cause.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti rytilahti added this to the 0.13 milestone Nov 1, 2026
o-gent and others added 2 commits November 1, 2026 19:51
@o-gent
Preserve hub child module data across partial updates
bd49aa4 
Merge module query responses instead of discarding cached responses for modules not due for refresh. Regress using existing Cloud and TriggerLogs modules on H100 and KH100 children, independent of new thermostat modules.

Co-authored-by: Copilot <[email protected]>
@o-gent
Log retained child module responses at debug level
b8fc90c 
Cover partial and missing responses, complete refreshes, and explicit errors without changing cache semantics.

Co-authored-by: Copilot <[email protected]>
@o-gent
o-gent force-pushed the fix-child-partial-update branch from 7fb9009 to b8fc90c Compare November 1, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti requested changes

Requested changes must be addressed to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.13

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@o-gent @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.