GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ThermostatSchedule module by o-gent · Pull Request #1816 · python-kasa/python-kasa

Conversation

@o-gent

@o-gent o-gent commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Split from #1806. Related to #1601.

Adds schedule enable/disable, week-mode selection, paginated schedule reads, and replacement of a day's slots. Preserves schedule_mode during pagination and validates coverage, gaps, overlaps, slot limits, and temperature bounds. Rejects edits outside the active mode.

Includes registration, exports, schedule fallbacks, the fake edit handler, and tests. Fixtures are submitted separately. No TPAP changes are included.

Validation: schedule, child-device, and common-module tests, Ruff checks, and targeted mypy passed.

The original PR documents hardware verification; no new hardware testing was performed during this split.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@o-gent
Add ThermostatSchedule module
a5b0195 
Read and toggle thermostat schedules, select the week mode, and replace a day's slots. Preserve mode-specific pagination and active-mode edit validation. Split from python-kasa#1806 without TPAP changes.

Co-authored-by: Copilot <[email protected]>
@o-gent
o-gent marked this pull request as ready for review October 25, 2026 23:01
@codecov

codecov Bot commented Oct 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.51%. Comparing base (e29864b) to head (a5b0195).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1816      +/-   ##
==========================================
+ Coverage   93.43%   93.51%   +0.08%     
==========================================
  Files         160      161       +1     
  Lines       10095    10231     +136     
  Branches     1042     1059      +17     
==========================================
+ Hits         9432     9568     +136     
  Misses        471      471              
  Partials      192      192

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti rytilahti added the enhancement New feature or request label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@o-gent @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.