GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix CLI echo of non-string output without rich by junkerderprovinz · Pull Request #1846 · python-kasa/python-kasa

Conversation

@junkerderprovinz

@junkerderprovinz junkerderprovinz commented Nov 7, 2026

Copy link
Copy Markdown

Hi, and thanks for keeping python-kasa in such good shape!

Without rich installed, the fallback _echo runs the rich tag regex over every message, so commands that print an object instead of a string fail with TypeError: expected string or bytes-like object. kasa feature check_latest_firmware is one example, as reported in #1618. The fallback now strips tags only from strings and hands everything else to click.echo unchanged, which is also what rich itself does with such objects (it never parses markup in them).

This picks up #1619 by @mash-graz, who found the cause and proposed the string check, so they are credited as co-author. Thank you, mash-graz! I added a test next to the existing test_echo_strips_rich_tags_without_rich that fails before the change and passes after it.

AI was used as a helper for this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
junkerderprovinz @mash-graz
Fix CLI echo of non-string output without rich
69bdd85
The fallback echo ran the rich tag regex over every message, so commands
that print an object raised a TypeError when rich is not installed.

Co-authored-by: mash-graz <[email protected]>
@codecov

codecov Bot commented Nov 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.49%. Comparing base (a679bc5) to head (69bdd85).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1846   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         161      161           
  Lines       10169    10169           
  Branches     1053     1053           
=======================================
  Hits         9508     9508           
  Misses        469      469           
  Partials      192      192           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@junkerderprovinz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.