GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not close out the session on connection error by bdraco · Pull Request #682 · python-kasa/python-kasa

Conversation

@bdraco

@bdraco bdraco commented Jan 23, 2024

Copy link
Copy Markdown
Member

The P100s drop the connection after every request

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bdraco
Do not close out the session on connection error
43f5443 
The P100s drop the connection after every request
@codecov

codecov Bot commented Jan 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37f522c) 86.96% compared to head (43f5443) 86.96%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   86.96%   86.96%   -0.01%     
==========================================
  Files          39       39              
  Lines        3506     3505       -1     
  Branches      894      894              
==========================================
- Hits         3049     3048       -1     
  Misses        378      378              
  Partials       79       79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696

sdb9696 commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Closing as covered by #689
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696 sdb9696 closed this Jan 23, 2024
@bdraco
bdraco deleted the no_close_connection_error branch January 23, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bdraco @sdb9696
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.