GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — notfy: give ack. about ruff linter and formatter by KMohZaid · Pull Request #94 · python-lsp/python-lsp-ruff

Conversation

@KMohZaid

@KMohZaid KMohZaid commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Like inbuilt plugins, ruff will also inform about linter and formatter working

it is actually useful because it inform user that pylsp is working properly and format is also working

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KMohZaid
notfy: give ack. about ruff linter and formatter
3c02ff0
@KMohZaid

KMohZaid commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

lol i thought my formatted did something but look like format needed for tests to past?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KMohZaid added 2 commits August 19, 2024 10:01
@KMohZaid
fix: ruff format message is shown even when it is disabled (my bad)
e5236cb
@KMohZaid
format: formatted to fix pre commit error (line length exceed format)
0ce805e
@KMohZaid

KMohZaid commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

Finally all checks passed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KMohZaid KMohZaid mentioned this pull request Aug 19, 2024
notfy: give ack. when black formatter runs python-lsp/python-lsp-black#61
Open
@jhossbach

jhossbach commented Aug 24, 2024

Copy link
Copy Markdown
Member

LGTM, thanks for your contribution!
FYI, you can use pre-commit to perform checks before committing, such as formatting etc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jhossbach
jhossbach merged commit 9117709 into python-lsp:main Aug 24, 2024
@KMohZaid

KMohZaid commented Aug 25, 2024

Copy link
Copy Markdown
Contributor Author

FYI, you can use pre-commit to perform checks before committing, such as formatting etc.

Yeah I knew but i didn't notice it is not configured when I was editing and committing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KMohZaid KMohZaid mentioned this pull request Oct 7, 2024
notfy: give ack. when isort formatter runs chantera/python-lsp-isort#5
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@KMohZaid @jhossbach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.