GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pydoctyle plugin: The 'match' option in a config file isn't ignored by vpunch · Pull Request #524 · python-lsp/python-lsp-server

Conversation

@vpunch

@vpunch vpunch commented Jan 27, 2024

Copy link
Copy Markdown

See #523 for a description of this error.

The author of the pydocstyle_lint.py module made a mistake when he thought that pydocstyle ignores the --match option when we explicitly pass the path to a file for diagnosis. This behavior only occurs with respect to the --match-dir option. The link to the source code that proves this. As a result, users were unable to set the match parameter in their configuration file inside a project.

I fixed this error and did a little refactoring to get rid of the repetitive code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vpunch
The 'match' option in a config file isn't ignored and small refactoring
bf2c3ce
@ccordoba12 ccordoba12 added this to the v1.11.1 milestone Mar 29, 2024
@ccordoba12
Merge branch 'develop' into develop
0512e56
@ccordoba12 ccordoba12 removed this from the v1.12.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vpunch @ccordoba12
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.