GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drop ujson and switch to orjson by rumpelsepp · Pull Request #579 · python-lsp/python-lsp-server

Conversation

@rumpelsepp

@rumpelsepp rumpelsepp commented Jul 16, 2024

Copy link
Copy Markdown

Implemented as requested in this comment:
#508 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ccordoba12
ccordoba12 reviewed Jul 30, 2024
View reviewed changes

@ccordoba12 ccordoba12 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help with this @rumpelsepp!

Besides these changes, you also need to replace ujson in python-lsp-jsonrpc for the switch to be complete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread pylsp/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp
rumpelsepp force-pushed the orjson branch 3 times, most recently from 4a01423 to ce08bbc Compare July 30, 2024 11:24
@rumpelsepp
Drop ujson and switch to orjson
5a053c7
@rumpelsepp
rumpelsepp force-pushed the orjson branch from ce08bbc to 5a053c7 Compare July 30, 2024 11:25
rumpelsepp added a commit to rumpelsepp/python-lsp-jsonrpc that referenced this pull request Jul 30, 2024
@rumpelsepp
Drop ujson and switch to orjson
178b632 
Implemented as requested in this comment:
python-lsp/python-lsp-server#579 (review)
@rumpelsepp rumpelsepp mentioned this pull request Jul 30, 2024
Drop ujson and switch to orjson python-lsp/python-lsp-jsonrpc#28
Closed
rumpelsepp added a commit to rumpelsepp/python-lsp-jsonrpc that referenced this pull request Jul 30, 2024
@rumpelsepp
Drop ujson and switch to orjson
3503923 
Implemented as requested in this comment:
python-lsp/python-lsp-server#579 (review)
@rumpelsepp

rumpelsepp commented Jul 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

I realized there is a typing issue with this. json.dumps() and orjson.dump() return different types. I will fix this. I am short on time today.
ccordoba12 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp
rumpelsepp marked this pull request as draft July 30, 2024 11:58
@rumpelsepp rumpelsepp mentioned this pull request Aug 12, 2024
Replace ujson with orjson python-lsp/python-lsp-jsonrpc#29
Open
valrus pushed a commit to valrus/python-lsp-jsonrpc that referenced this pull request Aug 17, 2024
@rumpelsepp @valrus
Drop ujson and switch to orjson
15b3545 
Implemented as requested in this comment:
python-lsp/python-lsp-server#579 (review)
@valrus valrus mentioned this pull request Aug 17, 2024
Replace ujson with orjson #591
Open
@ccordoba12

ccordoba12 commented Aug 18, 2024

Copy link
Copy Markdown
Member

Closing in favor of #591. Thanks for your work on this @rumpelsepp!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ccordoba12 ccordoba12 closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccordoba12 ccordoba12 ccordoba12 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rumpelsepp @ccordoba12
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.