GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix minor typo in workspace.py by Hoblovski · Pull Request #649 · python-lsp/python-lsp-server

Conversation

@Hoblovski

@Hoblovski Hoblovski commented May 21, 2025

Copy link
Copy Markdown
Contributor

enviroment -> environment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Hoblovski
Fix typo in workspace.py
41d1043
krassowski
krassowski reviewed May 28, 2025
View reviewed changes
Comment thread pylsp/workspace.py
return jedi.Script(**kwargs)

def get_enviroment(self, environment_path=None, env_vars=None):
def get_environment(self, environment_path=None, env_vars=None):

@krassowski krassowski May 28, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am nor sure if anyone uses it, but shall we preserve get_enviroment (with typo, but mention it is deprecated in docstring) and make it call get_environment (and return its result) to make sure we are not breaking plugins if any does use it?

Or do we assume this was not meant to be a public API? In that case, should it be renamed to start with underscore?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ccordoba12 ccordoba12 May 28, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @krassowski on this one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccordoba12 ccordoba12 ccordoba12 left review comments
@krassowski krassowski krassowski left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Hoblovski @ccordoba12 @krassowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.