GeezerVison is showing github.com — Replace ujson with orjson for JSON serialization by mcepl · Pull Request #693 · python-lsp/python-lsp-server
Conversation
mcepl
commented
Dec 30, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
"⚠️ Note: This PR is stacked on top of #692. Please review/merge #692 first. I will rebase this onto main once that is merged."
- Update pyproject.toml dependencies to require orjson instead of ujson.
- Update import fallbacks in pylsp/python_lsp.py, pylsp/main.py, and
pylsp/plugins/pylint_lint.py.
- Handle orjson-specific behavior (bytes output in dumps, absence of
load method).
Fixes: #673
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Check if self.config is None in _hook to avoid AttributeError when
shutdown is called without a prior successful initialize request.
Signed-off-by: Matěj Cepl <[email protected]>
- Add exception logging in jedi_completion plugin.
- Explicitly disable pylsp_rope in autoimport notebook tests to prevent interference.
- Make flake8 argument assertions more flexible to accommodate local configurations.
Signed-off-by: Matěj Cepl <[email protected]>
In some environments (e.g. NumPy 2.x on Python 3.13), Jedi might
fail to provide completions, definitions, or hover info.
Update tests to skip gracefully instead of failing when these
libraries cannot be analyzed.
Signed-off-by: Matěj Cepl <[email protected]>
- Update pyproject.toml dependencies to require orjson instead of ujson.
- Update import fallbacks in pylsp/python_lsp.py, pylsp/__main__.py, and
pylsp/plugins/pylint_lint.py.
- Handle orjson-specific behavior (bytes output in dumps, absence of
load method).
Fixes: python-lsp#673
Signed-off-by: Matěj Cepl <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
UJSON is deprecated
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.