GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Respect pydocstyle add-select and add-ignore settings by alloutflo · Pull Request #722 · python-lsp/python-lsp-server

Conversation

@alloutflo

@alloutflo alloutflo commented Aug 8, 2026

Copy link
Copy Markdown

Fixes #626

Summary

  • apply addSelect and addIgnore independently of the selected basic error list
  • add regression coverage for combining addIgnore with select and addSelect with ignore
  • clarify the generated configuration reference for both additive settings

Tests

  • pytest -q test/plugins/test_pydocstyle_lint.py (6 passed)
  • pytest -o addopts="" -q test/ -k "not test_missing_message" (203 passed, 9 skipped, 1 deselected)
  • ruff check pylsp test
  • ruff format --check pylsp test
  • JSON schema validation and generated configuration sync check

Local baseline note

test_missing_message has an unrelated teardown error on the unchanged develop branch with local Python 3.14 (config is None during shutdown), so it was excluded from the second full-suite run after confirming the same behavior against the baseline.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alloutflo
Fix pydocstyle add-select and add-ignore settings
7f89601
@alloutflo

alloutflo commented Aug 9, 2026

Copy link
Copy Markdown
Author

Maintainer handoff: the current head 7f89601a is mergeable and up to date with develop (0 commits behind). All four PR workflow runs—Linux, Windows, macOS, and static analysis—ended as action_required before creating any jobs (0 jobs each), so there is no contributor-side CI failure or log to fix.

The focused tests, broader test run, Ruff checks, and generated-configuration validation are recorded in the PR description. Please approve the fork workflows when convenient; if an actual job then fails, I can address that concrete failure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pydocstyle: addIgnore and addSelect are not respected unless convention is set

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@alloutflo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.