GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip generated symbols without a module path by natesute · Pull Request #729 · python-lsp/python-lsp-server

Conversation

@natesute

@natesute natesute commented Sep 30, 2026

Copy link
Copy Markdown

Importing a class produced by collections.namedtuple can make textDocument/documentSymbol fail with TypeError when Jedi supplies generated members whose module_path is None.

Skip those members before constructing a Path. The imported class and the document's own symbols retain their locations. Regression coverage exercises both values of all_scopes and include_import_symbols with a real relative import.

Fixes #635.

Validation: two regression cases fail before the fix and two controls pass. The symbols, definitions and type-definition suites pass after the fix (19 passed, 1 platform-specific test skipped). Ruff 0.9.4 lint and formatting checks pass for both changed files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@natesute
Skip generated symbols without a module path
738ca05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

textDocument/documentSymbol causes pylsp_document_symbols to throw a TypeError when there is an import for a namedtuple type

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@natesute
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.