GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip definitions without a source path by SAY-5 · Pull Request #730 · python-lsp/python-lsp-server

Conversation

@SAY-5

@SAY-5 SAY-5 commented Oct 5, 2026

Copy link
Copy Markdown

Go to definition on a collections.namedtuple field can return file:///None: Jedi supplies a generated definition with a line and column but no source path. Skip those definitions before building LSP locations. The existing position checks remain in place, and navigable source and builtin definitions retain their behavior.

Fixes #696.

Validation on Python 3.13 / Jedi 0.20.0: the real Document/Jedi regression fails before the fix with file:///None; three controls pass. After the fix, all 15 definition and type-definition tests pass, including both follow_builtin_definitions settings and source-backed locations. Ruff 0.9.4 lint and formatting pass for all 70 files in pylsp and test. The full platform/plugin suite was not run locally.

OpenAI Codex assisted with the code, regression tests, and this description. The final patch received an independent AI review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SAY-5
Skip definitions without a source path
def2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

neovim reacts badly to goto definitions on a namedtuple property

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@SAY-5
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.