GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix: skip non-image parts when matching by sha1 in ImageParts by TemRevil · Pull Request #1566 · python-openxml/python-docx ConversationCloses #1565. Problem
def _gather_image_parts(self): for rel in self.iter_rels(): if rel.is_external: continue if rel.reltype != RT.IMAGE: continue if rel.target_part in self.image_parts: continue self.image_parts.append(cast("ImagePart", rel.target_part)) The cast is only a type hint. If an image uses a type that does not load as an Once such a part is in the collection, the next FixSkip parts that have no for image_part in self._image_parts: if not hasattr(image_part, "sha1"): continue if image_part.sha1 == sha1: return image_part This mirrors the same fix already made in python-pptx ( TestsAdded Verified with
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsPackage._gather_image_parts appends every part reached through an image relationship to the ImageParts collection, casting it to ImagePart. When an image uses a type that does not load as an ImagePart (for example an SVG, or an image with broken or non-standard EXIF data), the target is a plain Part with no sha1 attribute. The next call to add_picture runs ImageParts._get_by_sha1, which reads .sha1 on every collected part, so it raised "'Part' object has no attribute 'sha1'" as soon as such a part was present. Skip parts that have no sha1 attribute while matching, mirroring the same fix in python-pptx. Add a unit test covering a non-image Part placed before the matching ImagePart in the collection.
This was referenced
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Error when doing run add_picture: 'Part' object has no attribute 'sha1'Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |