GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ensure Forward Compatibility of `Gift` and `Gifts` by Bibo-Joshi · Pull Request #4634 · python-telegram-bot/python-telegram-bot

Conversation

@Bibo-Joshi

@Bibo-Joshi Bibo-Joshi commented Jan 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This slipped in #4566 and causes test failures in #4626: https://github.com/python-telegram-bot/python-telegram-bot/actions/runs/12573766177/job/35058024511?pr=4626

closes #4637

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Bibo-Joshi
Ensure Forward Compatibility of Gift and Gifts
abf7a26
@Bibo-Joshi Bibo-Joshi added ⚙️ bot-api affected functionality: bot-api 🔌 bug pr description: bug labels Jan 2, 2025
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 2, 2025
Extend & Unify Deserialization Testing #4635
Open
@Bibo-Joshi
Bibo-Joshi merged commit 679d038 into master Jan 2, 2025
@Bibo-Joshi
Bibo-Joshi deleted the forward-compat branch January 2, 2025 08:17
@harshil21 harshil21 mentioned this pull request Jan 3, 2025
TypeError: Gift.__init__() got an unexpected keyword argument 'upgrade_star_count' #4637
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api 🔌 bug pr description: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Gift.__init__() got an unexpected keyword argument 'upgrade_star_count'

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Bibo-Joshi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.