GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge `ARRAY_OF_EXCEPTIONS` into `COMPLEX_TYPES` in `test_official` by kurupdevs · Pull Request #5367 · python-telegram-bot/python-telegram-bot

Conversation

@kurupdevs

@kurupdevs kurupdevs commented Sep 28, 2026

Copy link
Copy Markdown

Related to #4324

Resolves the TODO in tests/test_official/exceptions.py by merging ParamTypeCheckingExceptions.ARRAY_OF_EXCEPTIONS into COMPLEX_TYPES (one unchecked item of the tracking issue).

  • The six "Array of" exceptions are now entries in COMPLEX_TYPES, keyed by object name like all other entries, with string values that must be present in the parameter annotation.
  • check_param_type resolves them via extract_mappings(PTCE.COMPLEX_TYPES, ...) with identical return semantics.
  • Removed the now-unused Sequence import and the unreachable {"correct_option_ids": Sequence[int]} send_poll entry.

Behavior-preserving: verified with a script comparing old vs new exception-path decisions for all 6200 (object, parameter) pairs of telegram.Bot methods and telegram classes. ruff check, ruff format --check and py_compile pass.

Use "Related to #4324" (NOT "Closes") since #4324 is a tracking issue with other unchecked items.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kurupdevs
Merge ARRAY_OF_EXCEPTIONS into COMPLEX_TYPES in test_official exceptions
57b8ba0 
Resolves the TODO in tests/test_official/exceptions.py by folding the
"Array of" type exceptions (previously keyed by (param_name, is_class))
into COMPLEX_TYPES, keyed by object name like the other entries.
check_param_type now looks the exceptions up via extract_mappings.

Behavior is unchanged: verified with a script comparing the old and new
exception-path decisions for all 6200 (object, parameter) pairs of
telegram.Bot methods and telegram classes, plus end-to-end
check_param_type runs on the affected parameters.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kurupdevs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.