GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add filters.IS_BOT for bot-authored messages by ShahadatTest · Pull Request #5384 · python-telegram-bot/python-telegram-bot

Conversation

@ShahadatTest

@ShahadatTest ShahadatTest commented Oct 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Add filters.IS_BOT so message handlers can select messages whose sender is a bot. It checks Update.effective_user.is_bot, following the existing user-attribute filters. A missing sender returns False; via_bot does not determine whether the sender is a bot.

Closes #5315. The constant is exported, documented through the existing filters automodule, and marked versionadded:: NEXT.VERSION.

Tests follow the existing filter-test style: mutate the sender's is_bot flag and assert the result directly. A separate test covers a missing sender using a fresh fixture, since Update.effective_user caches a resolved user.

Validation on Windows with CPython 3.14.6:

  • pytest tests/ext/test_filters.py --disable-socket -q: 217 passed.
  • prek run --files tests/ext/test_filters.py: Ruff lint and formatting passed; source-only hooks skipped because this update changes tests only.
  • git diff --check: passed.

The existing Chango workflow handles the PR's changelog fragment.

AI disclosure: the implementation, tests, and this description were prepared with OpenAI Codex.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShahadatTest
Add a filter for bot-authored messages
2c330d9
harshil21
harshil21 reviewed Oct 21, 2026
View reviewed changes
Comment thread tests/ext/test_filters.py Outdated
Comment on lines +2170 to +2192
@pytest.mark.parametrize(
"message_type",
[
"message",
"edited_message",
"channel_post",
"edited_channel_post",
"business_message",
"edited_business_message",
"guest_message",
],
)
@pytest.mark.parametrize("is_bot", [True, False, None])
def test_filters_is_bot(self, update, message_type, is_bot):
if is_bot is None:
update.message.from_user = None
else:
update.message.from_user.is_bot = is_bot
message_update = Update(0, **{message_type: update.message})

assert filters.IS_BOT.check_update(message_update) is (is_bot is True)
assert (~filters.IS_BOT).check_update(message_update) is (is_bot is not True)

@harshil21 harshil21 Oct 21, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no make this test like the others

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShahadatTest
Align IS_BOT tests with existing filter tests
a43d0f8

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshil21 harshil21 harshil21 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add filters.IS_BOT — no filter exposes User.is_bot (needed for multi-bot group chats)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShahadatTest @harshil21
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.