GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Keep the LRU order of `CallbackDataCache` when persisting it by waw666waw666 · Pull Request #5397 · python-telegram-bot/python-telegram-bot ConversationWith
cdc = CallbackDataCache(bot, maxsize=2) menu = ... # keyboard sent first, pressed regularly old = ... # keyboard sent later, never pressed again # press a button of `menu` cdc.persistence_data # what update_persistence does cdc.process_keyboard(new_markup) # evicts `menu` instead of `old` Changes proposed in this pull request:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsReading persistence_data went through LRUCache.__getitem__ for every keyboard, which marked all keyboards as just used in insertion order. Since Application.update_persistence reads it periodically, the most used keyboards could become the first ones to be evicted. Loading the data also inserted the keyboards in that order. Read the keyboards without touching the LRU order, return them sorted by access time and insert them in that order when loading. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |