Description

johtso

opened on Oct 5, 2020

Issue body actions

Think this would be a generally very useful feature. Easy to structure your code so that various things have Async/Sync prefixes, and then you can just target them all with a regex instead of having to list every token.

This is something that httpcore are doing in their custom unasync script https://github.com/encode/httpcore/blob/0.11.1/unasync.py#L10

Reacted by david-alm and Alexandru Dreptu

Activity

1. pquentin commented on Oct 5, 2020

   

   pquentin

   on Oct 5, 2020

   Member

   More actions

   Would additional_replacements be enough for your needs? https://unasync.readthedocs.io/en/latest/#usage
2. johtso commented on Oct 5, 2020

   

   johtso

   on Oct 5, 2020

   Author

   More actions

   Well, that's still just string for string replacement, no regexes right?

   I did just realise that with the case of Async/Sync prefixed class names, we just hard-code the replacement. https://github.com/python-trio/unasync/blob/master/src/unasync/__init__.py#L106-L108

   A guess a small benefit of having it implemented as a regex is that it will then be with all the other default replacements at the top of the file rather than hidden in the code.

Issue actions