GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace tokenization with tokenize_rt by pquentin · Pull Request #77 · python-trio/unasync

Conversation

@pquentin

@pquentin pquentin commented Jul 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The standard library module tokenize does not round trip, so we had to
implement our own tokenization on top of it. However, tokenize_rt does
it better and will enable #75, so let's adopt it instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pquentin
Replace tokenization with tokenize_rt
69cfc3c 
The standard library module `tokenize` does not round trip, so we had to
implement our own tokenization on top of it. However, tokenize_rt does
it better, so let's adopt it instead.
@codecov

codecov Bot commented Jul 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #77 (ce69cb5) into master (0d21b04) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          110        93   -17     
  Branches        31        26    -5     
=========================================
- Hits           110        93   -17
Impacted Files Coverage Δ
src/unasync/__init__.py 100.00% <100.00%> (ø)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sethmlarson
sethmlarson approved these changes Jul 22, 2022
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thanks tokenize_rt! Only thing that stood out to me was the version pin but if we have a good reason that's fine for me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pquentin added 2 commits July 22, 2022 14:48
@pquentin
Drop version pin
e6742b5
@pquentin
Fix pip upgrade on Windows
ce69cb5
@pquentin

pquentin commented Jul 22, 2022

Copy link
Copy Markdown
Member Author

Thanks, I removed the pin! Also fixed Windows CI. Can you please take another look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sethmlarson
sethmlarson approved these changes Jul 22, 2022
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pquentin
pquentin merged commit 1b6fd0c into python-trio:master Jul 22, 2022
@pquentin

pquentin commented Jul 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@asottile Thank you for tokenize_rt!
@sethmlarson Thank you for the reviews!
sethmlarson reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pquentin @sethmlarson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.