GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Issue 1359 by hansthen · Pull Request #2159 · python-visualization/folium

Conversation

@hansthen

@hansthen hansthen commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

This adds a Class.include statement.

This allows users to override methods on the Leaflet level.

This can be used to override the createTile method in Leaflet by adding a Bearer Token to the request. A motivating example can be found in the tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
hansthen added 2 commits June 9, 2025 21:41
@hansthen
Fix for issue 1359
b97053b
This includes a structural change. I added a Class object with
a include method. This follows leaflet's `L.Class.include`
statement. This allows users to override Leaflet class behavior.

The motivating example for this can be found in the added
`test_include` in `test_map.py`. Using an include, users can
override the `createTile` method of `L.TileLayer` and add
a headers.
@hansthen
Close #1359
f3df6f0
Add an include statement, that will allow users to override
specific methods at Leaflet level. This allows users to customize
the "createTile" method using a JsCode object.
@hansthen
hansthen requested review from Conengmo and ocefpaf June 10, 2025 06:05
hansthen added 2 commits June 10, 2025 19:48
@hansthen
Add typing annotations
db56f6a
@hansthen
Merge branch 'main' into issue_1359
c829e8c
ocefpaf
ocefpaf reviewed Jun 16, 2025
View reviewed changes
Comment thread tests/test_map.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ocefpaf

ocefpaf commented Jun 16, 2025

Copy link
Copy Markdown
Member

This PR needed docs, linting/formatting fixes, and I'm not sure why Streamlit tests are not passing.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hansthen added 3 commits June 16, 2025 20:02
@hansthen
Fix formatting issue
e677dbe
@hansthen
Add documentation
b2f98cd
@hansthen
Add link to new doc
e1ea6b2
@hansthen

hansthen commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

This PR needed docs, linting/formatting fixes, and I'm not sure why Streamlit tests are not passing.

Noted. The Streamlit tests I solved while fixing another issue and will be gone after a rebase.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hansthen added 2 commits June 16, 2025 20:27
@hansthen
Removed debugging code
13899c8
@hansthen
Fix doc issue
9d6e373
@hansthen
hansthen requested a review from ocefpaf June 16, 2025 18:37
ocefpaf
ocefpaf approved these changes Jun 16, 2025
View reviewed changes
@hansthen
hansthen merged commit 5c46067 into python-visualization:main Jun 16, 2025
@williambdean williambdean mentioned this pull request Oct 25, 2026
Fix dead link in override_leaflet_class_methods docs #2319
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocefpaf ocefpaf ocefpaf approved these changes
@Conengmo Conengmo Awaiting requested review from Conengmo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hansthen @ocefpaf
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.