GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for timeout. Change from select syscall to poll by nveloso · Pull Request #210 · python-xlib/python-xlib

Conversation

@nveloso

@nveloso nveloso commented Oct 18, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hi! In this PR I added support for specifying the timeout used in sockets via an argument.
I changed the use of select syscall to poll syscall. Select syscall has a known limitation:

WARNING: select() can monitor only file descriptors numbers that
are less than FD_SETSIZE (1024)—an unreasonably low limit for
many modern applications—and this limitation will not change.
All modern applications should instead use poll(2) or epoll(7),
which do not suffer this limitation.

Taken from https://man7.org/linux/man-pages/man2/select.2.html

I also make the BaseDisplay class public because it can be useful to connect to a X11 server without making several requests to get all the extensions available.

I also added a check in parse_connection_setup method that checks if the response has a valid status. In the protocol specification page 11 and 114 you can see all the available status (0, 1 or 2).

I ran the tests with python3 runtests.py and all passed.

----------------------------------------------------------------------
XML: /com.docker.devenvironments.code/nosetests.xml
----------------------------------------------------------------------
Ran 524 tests in 12.184s

OK (SKIP=142)

I hope you can merge my changes. Any question feel free to ask.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
nunovelosobs and others added 2 commits October 18, 2021 14:11
@nunovelosobs
Add support for timeout. Change from select syscall to poll. Add veri…
b42ef34
…fication in server connection setup response. Make BaseDisplay class public
@nveloso
Add TimeoutError class to py2 code
c1e928b
@codecov-commenter

codecov-commenter commented Oct 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #210 (c1e928b) into master (1a30315) will increase coverage by 0.04%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   78.12%   78.16%   +0.04%     
==========================================
  Files          41       41              
  Lines        4645     4704      +59     
==========================================
+ Hits         3629     3677      +48     
- Misses       1016     1027      +11     
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nveloso @codecov-commenter @nunovelosobs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.