GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — __all__ missing actual imports by Avasam · Pull Request #238 · python-xlib/python-xlib

Conversation

@Avasam

@Avasam Avasam commented Nov 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Two changes

  1. Added missing imports for modules re-exported in __all__.
  2. Exported symbol list may be incorrect if an operation is done on __all__.

Closes #240

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Avasam
Avasam force-pushed the __all__+imports branch from 71f308f to f893350 Compare November 4, 2022 22:10
Avasam
Avasam commented Nov 18, 2022
View reviewed changes
Comment thread Xlib/ext/randr.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vasily-v-ryabov

vasily-v-ryabov commented Dec 25, 2022

Copy link
Copy Markdown
Collaborator

If it's still actual, please resolve conflicts.
Avasam reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov-commenter

codecov-commenter commented Dec 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #238 (92fd325) into master (4e8bbf8) will increase coverage by 4.58%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   78.21%   82.80%   +4.58%     
==========================================
  Files          42       63      +21     
  Lines        4705     7484    +2779     
==========================================
+ Hits         3680     6197    +2517     
- Misses       1025     1287     +262
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Avasam

Avasam commented Jul 8, 2023

Copy link
Copy Markdown
Contributor Author

@vasily-v-ryabov Conflicts have been resolved. Could I get a review on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Avasam

Avasam commented Aug 18, 2024

Copy link
Copy Markdown
Contributor Author

@python-xlib @vasily-v-ryabov bump
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Avasam
__all__ missing actual imports
2654e8c
@Avasam
Avasam force-pushed the __all__+imports branch from 92fd325 to 2654e8c Compare October 30, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unnecessary import

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Avasam @vasily-v-ryabov @codecov-commenter
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.