GeezerVison is showing github.com — Removed unused imports by Avasam · Pull Request #239 · python-xlib/python-xlib
Conversation
Avasam
commented
Nov 4, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Found a handful of unused imports.
The dependency on tkinter was also unnecessary as it was only importing a single constant (which is not even used by Xlib). I kept the constant so this doesn't count as a breaking change (idk if it's meant to be part of the protocol).
Fixes #240
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
vasily-v-ryabov reacted with thumbs up emoji
|
The constant isn't part of the protocol. It was IMO erroneously introduced in c87624d. I also remove this import in #242. I hadn't noticed your PR at the time.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Merging #239 (25971f6) into master (333fbcb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 78.25% 78.23% -0.03%
==========================================
Files 42 42
Lines 4710 4704 -6
==========================================
- Hits 3686 3680 -6
Misses 1024 1024 |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Unnecessary import
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.