GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update type comparison by Avasam · Pull Request #246 · python-xlib/python-xlib

Conversation

@Avasam

@Avasam Avasam commented Nov 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Updated type comparison to ones that are more idiomatic and understood by type-checkers
    • getattr instead of hasattr when applicable
    • isinstance(x) instead of type(x) ==
  • is None instead of == None
  • set_cooler_manual_control_enabled was comparing a bool against 1. Which is redundant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codecov-commenter

codecov-commenter commented Nov 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #246 (9cb486a) into master (4e8bbf8) will not change coverage.
The diff coverage is 69.23%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files          42       42           
  Lines        4705     4705           
=======================================
  Hits         3680     3680           
  Misses       1025     1025
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vasily-v-ryabov

vasily-v-ryabov commented Dec 25, 2022

Copy link
Copy Markdown
Collaborator

Please resolve conflicts.
Avasam reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Avasam

Avasam commented Jul 8, 2023

Copy link
Copy Markdown
Contributor Author

@vasily-v-ryabov Conflicts has been resolved. Could I get a review on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Avasam

Avasam commented Aug 18, 2024

Copy link
Copy Markdown
Contributor Author

@python-xlib @vasily-v-ryabov bump
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Avasam
Update type comparison
c962168 
Updated type comparison to one that is understood by type-checkers
- `is None` instead of `== None`
- `set_cooler_manual_control_enabled` was comparing a bool agains `1`. Which would always return `False`
- `getattr` instead of `hasattr` when applicable
@Avasam
Avasam force-pushed the type-comparisons branch from 855dd10 to c962168 Compare April 11, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Avasam @codecov-commenter @vasily-v-ryabov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.