GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — attempt to support modern Python3 versions by a-detiste · Pull Request #276 · python-xlib/python-xlib

Conversation

@a-detiste

@a-detiste a-detiste commented Oct 6, 2024

Copy link
Copy Markdown

python-xlib is today the top-most remaining user of six. We slowly try to remove six from the distribution

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GanerCodes, R1kaB3rN, s-t-e-v-e-n-k, and Avasam reacted with rocket emoji
All reactions
  • 🚀 4 reactions
@a-detiste
attempt to support modern Python3 versions
d7fed2a
Avasam
Avasam suggested changes Apr 11, 2025
View reviewed changes

@Avasam Avasam left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a few additional replacements you're still missing:

six.MAXSIZE > sys.maxsize
six.iterbytes > iter
six.moves._thread > _thread
six.byte2int > operator.itemgetter(0), or just access [0] directly
six.text_type > str Only used where it's already a str, so just remove
six.indexbytes > Access directly with []
six.create_unbound_method > Just use the function directly

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread examples/xlsatoms.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/xlsatoms.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/xlsatoms.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-detiste

a-detiste commented Apr 12, 2025

Copy link
Copy Markdown
Author

Thanks.

I will réconciliate your tweaks with the one that ended up in the Debian patch https://sources.debian.org/src/python-xlib/0.33-3/debian/patches/remove_six.patch/
Avasam and R1kaB3rN reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-detiste
finish removing "six"
74b8668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Avasam Avasam Avasam requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@a-detiste @Avasam
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.