GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Return raw XID when resource table is absent by barlowa124 · Pull Request #297 · python-xlib/python-xlib

Conversation

@barlowa124

@barlowa124 barlowa124 commented Oct 11, 2026

Copy link
Copy Markdown

Summary

Fixes #281.

protocol.display.Display.get_resource_class reads self.resource_classes, an attribute populated only by the Xlib.display.Display wrapper when the xobject layer loads. A display opened at the protocol level, as examples/draw-proto.py does with display.Display() from Xlib.protocol, has no such table. Parsing any reply containing a resource-typed field then failed with AttributeError: 'Display' object has no attribute 'resource_classes', which is the traceback in the issue.

The lookup now falls back to an empty table and returns the caller's default. The reply decoder already treats a missing class as "return the raw XID", so protocol-level users get the XID integer back rather than a crash, matching what the test suite's DummyDisplay has always done.

New test/test_protocol_display.py covers the bare-display fallback and the resource-field decode path that raised in the report, plus normal lookups on a populated table.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barlowa124
protocol.display: tolerate missing resource_classes in get_resource_c…
bce787d 
…lass

Display.get_resource_class reads self.resource_classes, which is only
populated by the Xlib.display.Display wrapper (xobject layer). Displays
opened at the protocol level, as in examples/draw-proto.py, have no such
table, so parsing any reply containing a resource-typed field failed
with AttributeError: 'Display' object has no attribute 'resource_classes'.

Fall back to an empty table so the lookup returns the caller's default,
which the reply decoder already handles by passing the raw XID through.

Fixes python-xlib#281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

draw-proto.py example returns AttributeError on Ubuntu 22.04 python-xlib v.033 installed from source

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barlowa124
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.