GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Avoid quadratic buffer concatenation when receiving large replies by Avasam · Pull Request #298 · python-xlib/python-xlib

Conversation

@Avasam

@Avasam Avasam commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

send_and_recv rebuilt data_recv as a new bytes object on every socket read, copying everything received so far. A reply spanning N reads cost O(N^2) copying, which dominates large GetImage requests.

Once a packet's length is known, hold incoming chunks in a list and join them only when the packet is complete. Connection setup and packets whose header hasn't arrived yet are handled as before.

GetImage of a full 3840x2160 ZPixmap on Xvfb: ~245 ms -> ~70 ms.
1920x1080: ~13.5 ms -> ~11.5 ms. Small replies are unchanged.

AI Disclaimer: Claude Opus 5.5 found this whilst testing performance improvements for https://github.com/Toufool/AutoSplit . I don't know what's these maintainers view on LLM-generated code. And the project doesn't seem actively maintained either. But I figured I may as well share the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Avasam @claude
Avoid quadratic buffer concatenation when receiving large replies
b1be436
`send_and_recv` rebuilt `data_recv` as a new `bytes` object on every
socket read, copying everything received so far. A reply spanning N
reads cost O(N^2) copying, which dominates large `GetImage` requests.

Once a packet's length is known, hold incoming chunks in a list and
join them only when the packet is complete. Connection setup and
packets whose header hasn't arrived yet are handled as before.

`GetImage` of a full 3840x2160 `ZPixmap` on Xvfb: ~245 ms -> ~70 ms.
1920x1080: ~13.5 ms -> ~11.5 ms. Small replies are unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Avasam
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.