GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — encode strings to utf-8 in ServiceInfo by jgrill · Pull Request #10 · python-zeroconf/python-zeroconf

Conversation

@jgrill

@jgrill jgrill commented Dec 1, 2014

Copy link
Copy Markdown

I found that properties dict values registered as "False" rather than the intended string value, such as "path" in the provided examples.

eg.

Service Paul's Test Web Site._http._tcp.local. added
Type is _http._tcp.local.
Address is 10.0.1.2:80
Weight is 0, Priority is 0
Server is ash-2.local.
Properties are
path: False

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jgrill
encode strings to utf-8 in ServiceInfo
c2f05f1 
I found that properties dict values registered as "False" rather than the intended string value, such as "path" in the provided examples.

eg.

Service Paul's Test Web Site._http._tcp.local. added
  Type is _http._tcp.local.
  Address is 10.0.1.2:80
  Weight is 0, Priority is 0
  Server is ash-2.local.
  Properties are
    path: False
@coveralls

coveralls commented Dec 1, 2014

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) when pulling c2f05f1 on jgrill:master into 05c3c02 on jstasiak:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jstasiak

jstasiak commented Dec 12, 2014

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. I fixed it in f3fd4cd while refactoring the code. Feel free to reopen if it doesn't work for you for any reason.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jstasiak jstasiak closed this Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jgrill @coveralls @jstasiak @esazhin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.