GeezerVison

What

Switch RecordManager.async_remove_listener from set.remove() + except ValueError to set.discard(), so removing a listener that was never registered no longer raises.

Why

self.listeners is a set, so .remove(listener) raises KeyError on a missing element — not ValueError. The existing except ValueError clause could not catch the only realistic failure mode of that line, so the documented "log and continue" intent was effectively dead code. A teardown / reconnect path that double-removes a listener propagates KeyError out of Zeroconf.async_remove_listener and breaks the surrounding shutdown.

How

Use set.discard() (the set-native "remove if present" idiom) gated by if listener in self.listeners, so async_notify_all() only fires when something actually changed. The try / except is gone.

Testing

Added tests/test_handlers.py::test_async_remove_listener_missing_does_not_raise in a separate commit against the unfixed code first, so the before/after is explicit. Full suite (SKIP_CYTHON=1 pytest): 393 passed.

Quality Report

Changes: 2 files changed, 16 insertions(+), 4 deletions(-)

Code scan: clean

Tests: passed (4 PASSED)

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline